[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [PATCH] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()
From:       boris.ostrovsky () oracle ! com
Date:       2024-04-30 19:33:18
Message-ID: fee59103-4d70-4862-9f28-c718fb846552 () oracle ! com
[Download RAW message or body]



On 4/30/24 10:27 AM, Igor Mammedov wrote:
> On Fri,  3 Nov 2023 13:56:02 +0300
> Dmitrii Gavrilov <ds-gavr@yandex-team.ru> wrote:
> 
> Seems related to cpu hotpug issues,
> CCing Boris for awareness.

Thank you Igor.

This patch appears to change timing in my test which makes the problem 
much more difficult to reproduce. However, it can still be triggered if 
I insert a delay after qdev_device_add() which is roughly equivalent to 
what was happening in drain_call_rcu().

(https://lore.kernel.org/kvm/534247e4-76d6-41d2-86c7-0155406ccd80@oracle.com/ 
for context)



-boris

[prev in list] [next in list] [prev in thread] [next in thread]