[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [PATCH v2 6/7] target/hppa: Tidy read of interval timer
From:       Helge Deller <deller () gmx ! de>
Date:       2024-03-23 20:58:43
Message-ID: e02e4f25-edbb-4a0f-b8f4-6dea48e118dc () gmx ! de
[Download RAW message or body]

On 3/23/24 18:29, Richard Henderson wrote:
> The call to gen_helper_read_interval_timer is
> identical on both sides of the IF.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>

Thanks!
Helge

> ---
>   target/hppa/translate.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 8c1a564c5d..5b8c1b06c3 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -2082,11 +2082,9 @@ static bool trans_mfctl(DisasContext *ctx, arg_mfctl *a)
>           nullify_over(ctx);
>           tmp = dest_gpr(ctx, rt);
>           if (translator_io_start(&ctx->base)) {
> -            gen_helper_read_interval_timer(tmp);
>               ctx->base.is_jmp = DISAS_IAQ_N_STALE;
> -        } else {
> -            gen_helper_read_interval_timer(tmp);
>           }
> +        gen_helper_read_interval_timer(tmp);
>           save_gpr(ctx, rt, tmp);
>           return nullify_end(ctx);
>       case 26:


[prev in list] [next in list] [prev in thread] [next in thread]