[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [PATCH v1 10/24] vfio-user: get device info
From:       John Levon <levon () movementarian ! org>
Date:       2022-12-09 15:57:57
Message-ID: Y5NbBeoTnXLV/dwL () movementarian ! org
[Download RAW message or body]

On Tue, Nov 08, 2022 at 03:13:32PM -0800, John Johnson wrote:

> +/*
> + * VFIO_USER_DEVICE_GET_INFO
> + * imported from struct_device_info
> + */
> +typedef struct {
> +    VFIOUserHdr hdr;
> +    uint32_t argsz;
> +    uint32_t flags;
> +    uint32_t num_regions;
> +    uint32_t num_irqs;
> +    uint32_t cap_offset;
> +} VFIOUserDeviceInfo;

The server doesn't have or populate cap_offset - and this isn't in the protocol
either.

Looks good otherwise

regards
john

[prev in list] [next in list] [prev in thread] [next in thread]