[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios
From:       Anthony Liguori <anthony () codemonkey ! ws>
Date:       2013-09-30 22:57:55
Message-ID: CA+aC4kucLrgDJ2B4fDHukj8-AmG1kq0=3J7XspjsgQ-xuDhC7g () mail ! gmail ! com
[Download RAW message or body]

On Mon, Sep 30, 2013 at 5:43 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 01/10/2013 00:08, Anthony Liguori ha scritto:
> > Wouldn't this be logical as a machine option?  They way you are
> > introducing it makes it impossible to control with -global.
>
> You still have -bios.
>

Which cannot be versioned.


> We should introduce a machine object and convert unknown "-machine"
> options to -global on that object.


There's no need.  -global works on QemuOpts, not QObjects.  By making this
a machine option, you get -global and machine compat for free.

We also have a way to set per-machine default machine options already too.

Regards,

Anthony Liguori



>  But until that exists, IMO there's
> no reason to do anything different from what has been done so far.
>
> Paolo
>

[Attachment #3 (text/html)]

<div dir="ltr">On Mon, Sep 30, 2013 at 5:43 PM, Paolo Bonzini <span dir="ltr">&lt;<a \
href="mailto:pbonzini@redhat.com" target="_blank">pbonzini@redhat.com</a>&gt;</span> \
wrote:<br><div class="gmail_extra"><div class="gmail_quote">

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Il 01/10/2013 00:08, Anthony Liguori ha scritto:<br> \
<div>&gt; Wouldn&#39;t this be logical as a machine option?  They way you are<br> \
&gt; introducing it makes it impossible to control with -global.<br> <br>
</div>You still have -bios.<br></blockquote><div><br></div><div>Which cannot be \
versioned.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">

We should introduce a machine object and convert unknown &quot;-machine&quot;<br>
options to -global on that object.</blockquote><div><br></div><div>There&#39;s no \
need.  -global works on QemuOpts, not QObjects.  By making this a machine option, you \
get -global and machine compat for free.<br><br></div> <div>We also have a way to set \
per-machine default machine options already \
too.<br><br></div><div>Regards,<br><br>Anthony Liguori<br></div><div><br></div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">  But until that exists, IMO there&#39;s<br>
no reason to do anything different from what has been done so far.<br>
<span><font color="#888888"><br>
Paolo<br>
</font></span></blockquote></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]