[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route()
From:       Marcelo Tosatti <mtosatti () redhat ! com>
Date:       2012-06-29 23:02:59
Message-ID: 20120629230259.GA14304 () amt ! cnet
[Download RAW message or body]

On Mon, Jun 25, 2012 at 09:40:39AM -0600, Alex Williamson wrote:
> Anyone using these functions has to be prepared that irqchip
> support may not be present.  It shouldn't be up to the core
> code to determine whether this is a fatal error.  Currently
> code written as:
> 
> virq = kvm_irqchip_add_msi_route(...)
> if (virq < 0) {
>     <slow path>
> } else {
>     <fast path>
> }
> 
> works on x86 with and without kvm irqchip enabled, works
> without kvm support compiled in, but aborts() on !x86 with
> kvm support.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Applied to uq/master.


[prev in list] [next in list] [prev in thread] [next in thread]