[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH] target-i386: fix build with -Werror
From:       Blue Swirl <blauwirbel () gmail ! com>
Date:       2012-06-29 20:36:46
Message-ID: CAAu8pHuUcoy7yB7=y3zkzPQHbHk5tatDWpAqrJgdPhM1BL9v4w () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jun 29, 2012 at 7:35 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Am 29.06.2012 08:41, schrieb Dunrong Huang:
>>
>> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type
>> safety but raises compile error of incompatible pointer type. Fix it by
>> casting to correct function type Signed-off-by: Dunrong Huang
>> <riegamaths@gmail.com> --- target-i386/translate.c | 22
>> +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-)
>
>
> Adding type casts fixes the compilation, but also removes the
> type safety again. I'll send a patch which works without type
> casts in about 1/2 an hour.

The SSE tables with mixed function signatures should be replaced with
for example switch(). That would avoid all casts.

>
> Regards,
>
> Stefan W.
>

[prev in list] [next in list] [prev in thread] [next in thread]