[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH v2 01/11] dt: make setprop argument static
From:       Peter Crosthwaite <peter.crosthwaite () petalogix ! com>
Date:       2012-06-23 0:47:36
Message-ID: CAEgOgz4UHkgM1ahHgTkxrQ21gGe-sRotExsMFKdairQaHafmjA () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jun 21, 2012 at 11:33 PM, Alexander Graf <agraf@suse.de> wrote:
> Whatever we pass in to qemu_devtree_setprop to put into the device tree
> will not get modified by that function, so it can easily be declared cons=
t.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

Reviewed-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

> ---
> =A0device_tree.c | =A0 =A02 +-
> =A0device_tree.h | =A0 =A02 +-
> =A02 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index acae53e..b366fdd 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -127,7 +127,7 @@ static int findnode_nofail(void *fdt, const char *nod=
e_path)
> =A0}
>
> =A0int qemu_devtree_setprop(void *fdt, const char *node_path,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const char *property, v=
oid *val_array, int size)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const char *property, c=
onst void *val_array, int size)
> =A0{
> =A0 =A0 int r;
>
> diff --git a/device_tree.h b/device_tree.h
> index 4898d95..2244270 100644
> --- a/device_tree.h
> +++ b/device_tree.h
> @@ -18,7 +18,7 @@ void *create_device_tree(int *sizep);
> =A0void *load_device_tree(const char *filename_path, int *sizep);
>
> =A0int qemu_devtree_setprop(void *fdt, const char *node_path,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const char *property, v=
oid *val_array, int size);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const char *property, c=
onst void *val_array, int size);
> =A0int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const char *p=
roperty, uint32_t val);
> =A0int qemu_devtree_setprop_u64(void *fdt, const char *node_path,
> --
> 1.6.0.2
>
>

[prev in list] [next in list] [prev in thread] [next in thread]