[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
From:       Markus Armbruster <armbru () redhat ! com>
Date:       2008-07-30 16:31:17
Message-ID: m3iquncp0q.fsf () crossbow ! pond ! sub ! org
[Download RAW message or body]

Gerd Hoffmann <kraxel@redhat.com> writes:

> Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> +++ b/hw/xen-framebuffer.c
>>> @@ -0,0 +1,925 @@
>>> +/*
>>> + *  xen paravirt framebuffer backend
>> 
>> No copyright?
>> 
>
> Well, qemu-dm's xenfb.c which I used as base didn't have one.
> Guess most of this is Markus' code (CC'ed).
>
> cheers,
>   Gerd

Development history has been a bit more complicated than that :)

* Initial version: Anthony Liguori <anthony@codemonkey.ws>

  The link[*] to it has gone stale.  I don't think it had a copyright
  in the file that eventually mutated into the one we're discussing.

* Hacked into shape: me (xen-unstable changeset 12678).  No copyright
  in the source file.  Changeset carries:

  Signed-off-by: Markus Armbruster <armbru@redhat.com>
  Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

* Additional changes (use "hg log tools/xenfb in xen-unstable" to list
  them) by:

  Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
  Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
  Signed-off-by: Hirofumi Tsujimura <tsujimura.hirof@jp.fujitsu.com>
  Signed-off-by: Ian Campbell <ian.campbell@xensource.com>
  Signed-off-by: John Levon <john.levon@sun.com>
  Signed-off-by: Junko Ichino <ichino.junko@jp.fujitsu.com>
  Signed-off-by: Keir Fraser <keir@xensource.com>
  Signed-off-by: Markus Armbruster <armbru@redhat.com>
  Signed-off-by: Steven Smith <sos22@cam.ac.uk>
  Signed-off-by: Takanori Kasai <kasai.takanori@jp.fujitsu.com>
  Signed-off-by: Tsunehisa Doi <Doi.Tsunehisa@jp.fujitsu.com>

* Transformed from a separate program into a part of ioemu-dm:

  Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

* Additional changes (use "hg log tools/xenfb" to list them) by:

  Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
  Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
  Signed-off-by: Keir Fraser <keir@xensource.com>
  Signed-off-by: Markus Armbruster <armbru@redhat.com>
  Signed-off-by: Pat Campbell <plc@novell.com>
  Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
  Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

* Transformed to work on top of his common backend driver code in
  upstream QEMU:

  Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

I guess a copyright note should include at least Anthony, me, Dan,
Pat, Gerd (in order of first major contribution).  Perhaps something
like:

 * Copyright (C) 2005-2006 Anthony Liguori <aliguori@us.ibm.com>
 * Copyright (C) 2006-2008 Red Hat, Inc., Markus Armbruster <armbru@redhat.com>,
 *     Daniel P. Berrange <berrange@redhat.com>,
 *     Gerd Hoffmann <kraxel@redhat.com>
 * Copyright (C) 2008 Pat Campbell <plc@novell.com>

Apologies if I missed someone!

[*] http://www.cs.utexas.edu/users/aliguori/xen-vfb-20060124.bundle


[prev in list] [next in list] [prev in thread] [next in thread]