[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live
From:       Anthony Liguori <anthony () codemonkey ! ws>
Date:       2008-07-29 18:38:54
Message-ID: 488F63BE.5060804 () codemonkey ! ws
[Download RAW message or body]

andrzej zaborowski wrote:
> 2008/7/29 Paul Brook <paul@codesourcery.com>:
>   
>> No they aren't. I2C also supports 10-bit addressing.
>>     
>
> Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
> assumes this and current i2c api users do.
>   

But for the save/restore format, if the spec can support 10-bit 
addressing, then we should use be16s to avoid having to change 
save/restore format if we ever expand the supported address size.

Regards,

Anthony Liguori

> Regards
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   



[prev in list] [next in list] [prev in thread] [next in thread]