[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-devel
Subject:    Re: [Qemu-devel] Build failure on OS X
From:       Andreas_Färber <andreas.faerber () web ! de>
Date:       2007-09-30 15:54:55
Message-ID: 6E216391-AFD2-4037-A2DF-6AA491F9EB23 () web ! de
[Download RAW message or body]

Am 30.09.2007 um 17:05 schrieb Andreas Färber:

> Am 30.09.2007 um 16:37 schrieb J. Mayer:
>
>>> If someone has a speedup idea for the __APPLE__ case, that could
>>> still be applied separately.
>>
>> I guess there are some already defined macros in the Apple build
>> environmnet that should be used instead. But I don't know too much  
>> about
>> this environment... The slowdown is really not an issue in that
>> particular case.
>
> Actually, I am now seeing that in math.h Apple itself uses  
> __attribute__ ((always_inline)) for __MATH_H_ALWAYS_INLINE__ if  
> __GNUC__ is defined ... so I now believe the issue is rather the  
> "recursive" definition of always_inline: QEMU defines always_inline  
> and it subsequently tries to replace always_inline inside the  
> __attribute__(()) in math.h! Could this be it?

Puzzling, the attached patch works. It appears to be the trailing  
inline that it doesn't like for some reason.

Regards,

Andreas

["vl.h-exec-all.h-inline-2007-09-30.diff" (vl.h-exec-all.h-inline-2007-09-30.diff)]

Index: vl.h
===================================================================
RCS file: /sources/qemu/qemu/vl.h,v
retrieving revision 1.273
diff -r1.273 vl.h
113c113
< #if (__GNUC__ < 3) || defined(__APPLE__)
---
> #if (__GNUC__ < 3)
114a115,116
> #elif defined(__APPLE__)
> #define always_inline __attribute__ (( always_inline ))
Index: exec-all.h
===================================================================
RCS file: /sources/qemu/qemu/exec-all.h,v
retrieving revision 1.66
diff -r1.66 exec-all.h
41c41
< #if (__GNUC__ < 3) || defined(__APPLE__)
---
> #if (__GNUC__ < 3)
42a43,44
> #elif defined(__APPLE__)
> #define always_inline __attribute__ (( always_inline ))




[prev in list] [next in list] [prev in thread] [next in thread]