[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-commits
Subject:    [Qemu-commits] [qemu/qemu] 9341b2: python/qmp: allow sockets to be passed to connect()
From:       Richard Henderson via Qemu-commits <qemu-commits () nongnu ! org>
Date:       2023-05-31 21:32:50
Message-ID: qemu/qemu/push/refs/heads/staging/2d786c-982449 () github ! com
[Download RAW message or body]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 9341b2a6b99bd4ba6516cc5d69fc3424dcf7023c
      https://github.com/qemu/qemu/commit/9341b2a6b99bd4ba6516cc5d69fc3424dcf7023c
  Author: John Snow <jsnow@redhat.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/qmp/protocol.py

  Log Message:
  -----------
  python/qmp: allow sockets to be passed to connect()

Allow existing sockets to be passed to connect(). The changes are pretty
minimal, and this allows for far greater flexibility in setting up
communications with an endpoint.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20230517163406.2593480-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: b8d4ca18233dbd7c215c67b00fd3eb7887cf2b82
      https://github.com/qemu/qemu/commit/b8d4ca18233dbd7c215c67b00fd3eb7887cf2b82
  Author: John Snow <jsnow@redhat.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/qmp/legacy.py

  Log Message:
  -----------
  python/qmp/legacy: allow using sockets for connect()

Instead of asserting that we have an address, allow the use of sockets
instead of addresses during a call to connect().

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20230517163406.2593480-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: 7f5f3ae7d589d9297b2903e79cba1492807883d4
      https://github.com/qemu/qemu/commit/7f5f3ae7d589d9297b2903e79cba1492807883d4
  Author: John Snow <jsnow@redhat.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/machine/machine.py

  Log Message:
  -----------
  python/machine: use connect-based interface for existing sockets

Instead of using accept() with sockets (which uses open_with_socket()),
use calls to connect() to utilize existing sockets instead. A benefit of
this is more robust error handling already present within the connect()
call that isn't present in open_with_socket().

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20230517163406.2593480-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: 5bbc5936bb5b973848cbcabcc19346ffa812ae06
      https://github.com/qemu/qemu/commit/5bbc5936bb5b973848cbcabcc19346ffa812ae06
  Author: John Snow <jsnow@redhat.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/machine/machine.py
    M python/qemu/qmp/legacy.py

  Log Message:
  -----------
  python/qmp/legacy: remove open_with_socket() calls

Favor using connect() when passing a socket instead of
open_with_socket(). Simultaneously, update constructor calls to use the
combined address argument for QEMUMonitorProtocol().

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20230517163406.2593480-5-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: c76e7652c786683edcc846ee0a7a65b587787792
      https://github.com/qemu/qemu/commit/c76e7652c786683edcc846ee0a7a65b587787792
  Author: John Snow <jsnow@redhat.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/qmp/protocol.py

  Log Message:
  -----------
  Revert "python/qmp/protocol: add open_with_socket()"

This reverts commit a3cfea92e2030926e00a2519d299384ea648e36e.

(It's being rolled back in favor of a different API, which brings the
in-tree and out-of-tree versions of qemu.qmp back in sync.)

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20230517163406.2593480-6-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: 9824490dede64c1398b6a52095e5d22040529250
      https://github.com/qemu/qemu/commit/9824490dede64c1398b6a52095e5d22040529250
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M python/qemu/machine/machine.py
    M python/qemu/qmp/legacy.py
    M python/qemu/qmp/protocol.py

  Log Message:
  -----------
  Merge tag 'python-pull-request' of https://gitlab.com/jsnow/qemu into staging

Python: synchronize python-qemu-qmp

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE+ber27ys35W+dsvQfe+BBqr8OQ4FAmR3sUwACgkQfe+BBqr8
# OQ75GA/+NkO60LR6G7M68Wk2eaLlArlpWKa66lVTUPzIV+ERTzccjzFmEFhYM42z
# lJkkVieysuW/cFpjQqILSokfjiMOEH0XqC2R545vx0shZlExG6j6ky74jpFXxLCY
# 1tnZ/wOB97D1nO273T6taGfS6ZPBULaL+J2iCBuruEQiM9OKDQTjojLQYn+hRokL
# BZHF5fkMDts92GHBJdUo8ftYDyblDQ2SUQqdq0pgBgkt+kHlQ4wFB7O39HUwKwT7
# rnAYz7EGbumYGwDkuNSIbpJ2pPiX7SxSPmmrebVPlQ79town3XATLraVbllls5eO
# 8BvvkDakO7GvTkzcRvqcFnsnytWJvbEr0jPs1m8lQ2dMTv+NdZmsoItqGDP3LzVZ
# RU/Dr/8biKAbMXpSRH0Waddvmpb18I9I4U2NrVWDZ/vp6DqOFMgx/wUAVz0y0+3O
# M9o9Bj93YZhqBXhpShc75xjvaqJ10IzqG0roR0JbbskdbPmtIEvFlparxGDyH3cX
# UaQPKk8WdRCVOjtodqM28C441zMSUdL5ZCHB1LnMEhbTeV/MkR8W5KAXcYIzy2ay
# gh0FBYoiI8QNBGMR5AEpxdc3XKSSYFXlPGMz74yhlO1hWP1KZM1rE8OWHVfAPcwl
# T4xkw+Hoio9T6SlOWH4qwANaiaX9BII5Dv+L+UqqYt4+neeN8yk=
# =FvG2
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 31 May 2023 01:42:52 PM PDT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <jsnow@redhat.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* tag 'python-pull-request' of https://gitlab.com/jsnow/qemu:
  Revert "python/qmp/protocol: add open_with_socket()"
  python/qmp/legacy: remove open_with_socket() calls
  python/machine: use connect-based interface for existing sockets
  python/qmp/legacy: allow using sockets for connect()
  python/qmp: allow sockets to be passed to connect()

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/2d786cdffa7d...9824490dede6

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic