[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-commits
Subject:    [Qemu-commits] [qemu/qemu] aa1cbe: iotests.py: Enable faulthandler
From:       Machine user for deployment to qemu organization <noreply () github ! com>
Date:       2020-03-22 11:30:17
Message-ID: qemu/qemu/push/refs/heads/master/7b1e7c-e1df89 () github ! com
[Download RAW message or body]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: aa1cbeb86b4a44774b16042e2e84f236fc93c7db
      https://github.com/qemu/qemu/commit/aa1cbeb86b4a44774b16042e2e84f236fc93c7db
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2020-03-21 (Sat, 21 Mar 2020)

  Changed paths:
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  iotests.py: Enable faulthandler

With this, you can send SIGABRT to a hanging test case and you'll get a
Python stack trace so you know where it was hanging.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200313083617.8326-2-kwolf@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: cd87f5e3783a16ea5ae631855d7bb89116adf0c3
      https://github.com/qemu/qemu/commit/cd87f5e3783a16ea5ae631855d7bb89116adf0c3
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2020-03-21 (Sat, 21 Mar 2020)

  Changed paths:
    M python/qemu/machine.py

  Log Message:
  -----------
  python/qemu: Kill QEMU process if 'quit' doesn't work

With a QEMU bug, it can happen that the QEMU process doesn't react to a
'quit' QMP command. If we got an exception during previous QMP
communication (e.g. iotests Timeout expiring), we could also be in an
inconsistent state where after sending 'quit' we immediately read an old
response and close the socket even though the 'quit' command wasn't
processed yet. Both cases would lead to a hanging test.

Fix this by waiting for the QEMU process to exit after sending 'quit'
with a timeout, and if it doesn't happen within three seconds, send
SIGKILL.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200313083617.8326-3-kwolf@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: e1df89bbbc25eedd3a7e4ba46ec50ec07414200f
      https://github.com/qemu/qemu/commit/e1df89bbbc25eedd3a7e4ba46ec50ec07414200f
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2020-03-21 (Sat, 21 Mar 2020)

  Changed paths:
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  iotests: Increase pause_wait() timeout

Waiting for only 1 second proved to be too short on a loaded system,
resulting in false positives when testing pull requests. Increase the
timeout a bit to make this less likely.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200313083617.8326-4-kwolf@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7b1e7cb7c56f...e1df89bbbc25


[prev in list] [next in list] [prev in thread] [next in thread]