[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-commits
Subject:    [Qemu-commits] [qemu/qemu] 624532: softfloat: fix {min, max}nummag for same-abs-value...
From:       GitHub <noreply () github ! com>
Date:       2018-04-16 9:10:54
Message-ID: 5ad4689e60753_27dd2afac75dfc04289e7 () hookshot-fe-32b5f5b ! cp1-iad ! github ! net ! mail
[Download RAW message or body]


  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6245327a367292b354489c54e965646823023919
      https://github.com/qemu/qemu/commit/6245327a367292b354489c54e965646=
823023919
  Author: Emilio G. Cota <cota@braap.org>
  Date:   2018-04-13 (Fri, 13 Apr 2018)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  softfloat: fix {min, max}nummag for same-abs-value inputs

Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21),
we used to return +Zero for maxnummag(-Zero,+Zero); after that
commit, we return -Zero.

Fix it by making {min,max}nummag consistent with {min,max}num,
deferring to the latter when the absolute value of the operands
is the same.

With this fix we now pass fp-test.

Reviewed-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Message-id: 20180413140334.26622-2-alex.bennee@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 801bc56336a127d9b351b3a2cc0336e4d0cb2686
      https://github.com/qemu/qemu/commit/801bc56336a127d9b351b3a2cc0336e=
4d0cb2686
  Author: Alex Benn=C3=A9e <alex.bennee@linaro.org>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack=


The re-factor broke the raising of INVALID when NaN/Inf is passed to
the float_to_int conversion functions. round_to_uint_and_pack got this
right for NaN but also missed out the Inf handling.

Fixes https://bugs.launchpad.net/qemu/+bug/1759264

Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Tested-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20180413140334.26622-3-alex.bennee@linaro.org
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/38e83a71d02e...801bc56336a1=


[prev in list] [next in list] [prev in thread] [next in thread]