[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-commits
Subject:    [Qemu-commits] [qemu/qemu] 50d19c: cryptodev: setiv only when really need
From:       GitHub <noreply () github ! com>
Date:       2017-03-23 15:00:14
Message-ID: 58d3e2fe21ae6_2efb3fd750383c3817656d () hookshot-fe2-cp1-prd ! iad ! github ! net ! mail
[Download RAW message or body]


  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 50d19cf3681059efc8d2efcc585d2a19b9ab37c3
      https://github.com/qemu/qemu/commit/50d19cf3681059efc8d2efcc585d2a19b9ab37c3
  Author: Longpeng(Mike) <longpeng2@huawei.com>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M backends/cryptodev-builtin.c

  Log Message:
  -----------
  cryptodev: setiv only when really need

ECB mode cipher doesn't need IV, if we setiv for it then qemu
crypto API would report "Expected IV size 0 not **", so we should
setiv only when the cipher algos really need.

Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>


  Commit: b7bad50ae81efeb180609eeecdb086ebc7536ed7
      https://github.com/qemu/qemu/commit/b7bad50ae81efeb180609eeecdb086ebc7536ed7
  Author: Halil Pasic <pasic@linux.vnet.ibm.com>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M backends/cryptodev-builtin.c

  Log Message:
  -----------
  cryptodev: fix asserting single queue

We already check for queues == 1 in cryptodev_builtin_init and when that
is not true raise an error. But before that error is reported the
assertion in cryptodev_builtin_cleanup kicks in (because object is being
finalized and freed).

Let's remove assert(queues == 1) form cryptodev_builtin_cleanup as it
does only harm and no good.

Reported-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>


  Commit: b79fbb2d70524548abfb8482bd1e5713b5f7dcdc
      https://github.com/qemu/qemu/commit/b79fbb2d70524548abfb8482bd1e5713b5f7dcdc
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M backends/cryptodev-builtin.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/gonglei/tags/cryptodev-next-20170323' into staging

cryptodev fixes

# gpg: Signature made Thu 23 Mar 2017 09:22:44 GMT
# gpg:                using RSA key 0x2ED7FDE9063C864D
# gpg: Good signature from "Gonglei <arei.gonglei@huawei.com>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 3EF1 8E53 3459 E6D1 963A  3C05 2ED7 FDE9 063C 864D

* remotes/gonglei/tags/cryptodev-next-20170323:
  cryptodev: fix asserting single queue
  cryptodev: setiv only when really need

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/d81d857f4421...b79fbb2d7052

[prev in list] [next in list] [prev in thread] [next in thread]