[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-commits
Subject:    [Qemu-commits] [qemu/qemu] c3cb8e: ioport: remove LITTLE_ENDIAN mark for portio
From:       GitHub <noreply () github ! com>
Date:       2013-07-13 21:00:08
Message-ID: 51e1bfd84a8ea_75df1dd581972e () hookshot-fe2-pe1-prd ! aws ! github ! net ! mail
[Download RAW message or body]

----==_mimepart_51e1bfd84858b_75df1dd58195ef
Date: Sat, 13 Jul 2013 14:00:08 -0700
Mime-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-ID: <51e1bfd84a178_75df1dd58196fa@hookshot-fe2-pe1-prd.aws.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c3cb8e77804313e1be99b5f28a34a346736707a5
      https://github.com/qemu/qemu/commit/c3cb8e77804313e1be99b5f28a34a346736707a5
  Author: Anthony Liguori <aliguori@us.ibm.com>
  Date:   2013-07-12 (Fri, 12 Jul 2013)

  Changed paths:
    M ioport.c

  Log Message:
  -----------
  ioport: remove LITTLE_ENDIAN mark for portio

Setting it to LE forces a byte swap when host != guest endian but
this makes no sense at all.

Herve made the suggestion upon observing that word writes/reads
were broken into byte writes/reads in such a way as to assume
devices are interpret registers as LE.

However, even if this were a problem, marking the region as LE is
not useful because what's essentially happening here is that LE is
open coded.  So by marking it LE in MemoryRegionOps, we're doing a
superflous swap.

Now, the portio code is suspicious to begin with.  The dispatch
layer really has no purpose in splitting I/O requests in the first
place...

Cc: Hervé Poussineau <hpoussin@reactos.org>
Cc: Alex Graf <agraf@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>




----==_mimepart_51e1bfd84858b_75df1dd58195ef--


[prev in list] [next in list] [prev in thread] [next in thread]