[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    [PULL 12/27] block: avoid potential deadlock during bdrv_graph_wrlock() in bdrv_close()
From:       Kevin Wolf <kwolf () redhat ! com>
Date:       2023-10-31 18:59:03
Message-ID: 20231031185918.346940-13-kwolf () redhat ! com
[Download RAW message or body]

From: Fiona Ebner <f.ebner@proxmox.com>

by passing the BlockDriverState along, so the held AioContext can be
dropped before polling. See commit 31b2ddfea3 ("graph-lock: Unlock the
AioContext while polling") which introduced this functionality for
more information.

The only way to reach bdrv_close() is via bdrv_unref() and for calling
that the BlockDriverState's AioContext lock is supposed to be held.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20231019131936.414246-3-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index f9cf05ddcf..a527aa1a4c 100644
--- a/block.c
+++ b/block.c
@@ -5200,7 +5200,7 @@ static void bdrv_close(BlockDriverState *bs)
         bs->drv = NULL;
     }
 
-    bdrv_graph_wrlock(NULL);
+    bdrv_graph_wrlock(bs);
     QLIST_FOREACH_SAFE(child, &bs->children, next, next) {
         bdrv_unref_child(bs, child);
     }
-- 
2.41.0


[prev in list] [next in list] [prev in thread] [next in thread]