[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [PATCH v9 08/12] parallels: Fix statistics calculation
From:       "Denis V. Lunev" <den () virtuozzo ! com>
Date:       2023-01-31 15:34:02
Message-ID: b47909ea-a2ea-1e5c-b6aa-2e2ca5b17c87 () virtuozzo ! com
[Download RAW message or body]

On 1/31/23 11:27, Alexander Ivanov wrote:
> Exclude out-of-image clusters from allocated and fragmented clusters
> calculation.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
>   block/parallels.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index f9acee1fa8..7382c01191 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -510,7 +510,7 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
>       prev_off = 0;
>       for (i = 0; i < s->bat_size; i++) {
>           int64_t off = bat2sect(s, i) << BDRV_SECTOR_BITS;
> -        if (off == 0) {
> +        if (off == 0 || off + s->cluster_size > res->image_end_offset) {
>               prev_off = 0;
>               continue;
>           }
This requires explicit comment that the fix is applicable
for the case when BDRV_FIX_ERRORS is not set or
I am missed something in the context.

Den

[prev in list] [next in list] [prev in thread] [next in thread]