[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [PATCH 4/4] iotests/detect-zeroes-registered-buf: add new test
From:       Stefan Hajnoczi <stefanha () redhat ! com>
Date:       2023-01-30 20:46:05
Message-ID: Y9gsjecmU5K6eGRe () fedora
[Download RAW message or body]


On Fri, Jan 27, 2023 at 05:25:48PM -0600, Eric Blake wrote:
> On Thu, Jan 26, 2023 at 03:14:01PM -0500, Stefan Hajnoczi wrote:
> > This regression test demonstrates that detect-zeroes works with
> > registered buffers. Bug details:
> > https://gitlab.com/qemu-project/qemu/-/issues/1404
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > .../tests/detect-zeroes-registered-buf        | 58 +++++++++++++++++++
> > .../tests/detect-zeroes-registered-buf.out    |  7 +++
> > 2 files changed, 65 insertions(+)
> > create mode 100755 tests/qemu-iotests/tests/detect-zeroes-registered-buf
> > create mode 100644 tests/qemu-iotests/tests/detect-zeroes-registered-buf.out
> > 
> > diff --git a/tests/qemu-iotests/tests/detect-zeroes-registered-buf \
> > b/tests/qemu-iotests/tests/detect-zeroes-registered-buf new file mode 100755
> > index 0000000000..edb5f2cee5
> > --- /dev/null
> > +++ b/tests/qemu-iotests/tests/detect-zeroes-registered-buf
> > @@ -0,0 +1,58 @@
> > +#!/usr/bin/env bash
> > +# group: rw auto quick
> > +#
> > +# Check that detect-zeroes=unmap works on writes with registered I/O buffers.
> > +# This is a regression test for
> > +# https://gitlab.com/qemu-project/qemu/-/issues/1404 where I/O requests failed
> > +# unexpectedly.
> > +#
> > +# Copyright Red Hat
> 
> Do you need a year or a (C) or similar?

No, this is the cool new copyright style that Red Hat legal recommends!
> )

I'll send you the details in a separate email.

Stefan


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]