[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [PATCH v3 13/15] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests
From:       Max Reitz <mreitz () redhat ! com>
Date:       2021-04-30 13:24:14
Message-ID: 287d4f6a-c045-ac2b-3c27-c48d1ea5b4e6 () redhat ! com
[Download RAW message or body]

On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote:
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
>   docs/devel/testing.rst | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 2ee77a057b..62902cfd2d 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -236,6 +236,13 @@ given as options to the ``check`` script:
>     by setting the ``$GDB_QEMU`` environmental variable.
>     The final command line will be ``gdbserver $GDB_QEMU $QEMU ...``
>   
> +* ``-valgrind`` wraps a valgrind instance to QEMU. If it detects

Not a native speaker, but I think it should be "attaches ... to QEMU", 
"wraps QEMU in a valgrind instances", or "wraps ... around QEMU".

Apart from that:

Reviewed-by: Max Reitz <mreitz@redhat.com>

> +  warnings, it will print and save the log in
> +  ``$TEST_DIR/<valgrind_pid>.valgrind``.
> +  The final command line will be ``valgrind --log-file=$TEST_DIR/
> +  <valgrind_pid>.valgrind --error-exitcode=99 $QEMU ...``
> +  Note: if used together with ``-gdb``, this command will be ignored.
> +
>   * ``-d`` (debug) just increases the logging verbosity, showing
>     for example the QMP commands and answers.
>   
> 


[prev in list] [next in list] [prev in thread] [next in thread]