[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] [PATCH v3 08/33] Add function to control reset with gpio inputs
From:       Damien Hedde <damien.hedde () greensocs ! com>
Date:       2019-07-31 10:09:00
Message-ID: 4e30472f-1800-af8f-4bd2-18ce7147162b () greensocs ! com
[Download RAW message or body]



On 7/31/19 8:11 AM, David Gibson wrote:
> On Mon, Jul 29, 2019 at 04:56:29PM +0200, Damien Hedde wrote:
>> It adds the possibility to add 2 gpios to control the warm and cold reset.
>> With theses ios, the reset can be maintained during some time.
>> Each io is associated with a state to detect level changes.
>>
>> Vmstate subsections are also added to the existsing device_reset
>> subsection.
> 
> This doesn't seem like a thing that should be present on every single
> DeviceState.

I can revert to previous version where the io state has to be explicitly
added in devices using it.

Damien


[prev in list] [next in list] [prev in thread] [next in thread]