[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] [PATCH v2] block: maintain persistent disabled bitmaps
From:       Max Reitz <mreitz () redhat ! com>
Date:       2018-01-31 19:04:06
Message-ID: 9ac62cef-4331-a828-5c4d-b7a2fdd7b6b5 () redhat ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 2018-01-29 19:43, Max Reitz wrote:
> On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
>> To maintain load/store disabled bitmap there is new approach:
>>
>>  - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
>>  - store enabled bitmaps as "auto" to qcow2
>>  - store disabled bitmaps without "auto" flag to qcow2
>>  - on qcow2 open load "auto" bitmaps as enabled and others
>>    as disabled (except in_use bitmaps)
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Reviewed-by: John Snow <jsnow@redhat.com>
>> ---
> 
> Thanks, looks very reasonable.  Applied to my block branch:
> 
> https://github.com/XanClic/qemu/commits/block

...aaand I've only just now seen that iotest 176 will need to be fixed
along with this, so I'm going to unqueue this patch for now.

And when I'm already at it: Should we add deprecation information to
qemu-doc.texi?

Max


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]