[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] [Qemu-devel] [PATCH v4 19/23] qemu-img: Change img_rebase() to be byte-based
From:       John Snow <jsnow () redhat ! com>
Date:       2017-09-29 19:38:18
Message-ID: c7c22b4d-292e-5a25-1b2b-880a1bf5b962 () redhat ! com
[Download RAW message or body]



On 09/13/2017 12:03 PM, Eric Blake wrote:
> In the continuing quest to make more things byte-based, change
> the internal iteration of img_rebase().  We can finally drop the
> TODO assertion added earlier, now that the entire algorithm is
> byte-based and no longer has to shift from bytes to sectors.
> 
> Most of the change is mechanical ('num_sectors' becomes 'size',
> 'sector' becomes 'offset', 'n' goes from sectors to bytes); some
> of it is also a cleanup (use of MIN() instead of open-coding,
> loss of variable 'count' added earlier in commit d6a644bb).
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>


Reviewed-by: John Snow <jsnow@redhat.com>


[prev in list] [next in list] [prev in thread] [next in thread]