[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] [PATCH v2 1/2] vvfat: Fix volume name assertion
From:       Stefan Hajnoczi <stefanha () gmail ! com>
Date:       2016-04-29 9:07:55
Message-ID: 20160429090755.GA20753 () stefanha-x1 ! localdomain
[Download RAW message or body]


On Thu, Apr 28, 2016 at 01:36:05PM +0200, Kevin Wolf wrote:
> Commit d5941dd made the volume name configurable, but it didn't consider
> that the rw code compares the volume name string to assert that the
> first directory entry is the volume name. This made vvfat crash in rw
> mode.
> 
> This fixes the assertion to compare with the configured volume name
> instead of a literal string.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/vvfat.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

I just noticed that Wolfgang's original patch got rid of the default
"QEMU VVFAT " volume label.  It now defaults to all spaces but I'm not
sure if this causes any problems...

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]