[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] [PATCH 09/16] block: Split bdrv_move_feature_fields()
From:       Max Reitz <mreitz () redhat ! com>
Date:       2015-09-30 14:51:43
Message-ID: 560BF6FF.6010501 () redhat ! com
[Download RAW message or body]


On 17.09.2015 15:48, Kevin Wolf wrote:
> After bdrv_swap(), some fields must be moved back to their original BDS
> to compensate for the effects that a swap of the contents of the objects
> has while keeping the old addresses. Other fields must be moved back
> because they should logically be moved and must stay on top
> 
> When replacing bdrv_swap() with operations changing the pointers in the
> parents, we only need the latter and must avoid swapping the former.
> Split the function accordingly.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>

(and an ACK to "Op blockers are a mess.")


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]