[prev in list] [next in list] [prev in thread] [next in thread]
List: qemu-block
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v4 5/6] block: Drop BlockDriverState.filename
From: Eric Blake <eblake () redhat ! com>
Date: 2015-08-31 21:50:06
Message-ID: 55E4CC0E.3030601 () redhat ! com
[Download RAW message or body]
On 08/18/2015 05:10 PM, Max Reitz wrote:
> That field is now only used during initialization of BlockDriverStates
> (opening images) and for error or warning messages. Performance is not
> that much of an issue here, so we can drop the field and replace its use
> by a call to bdrv_filename() or bdrv_filename_alloc(). By doing so we
> can ensure the result always to be recent, whereas the contents of
> BlockDriverState.filename may have been obsoleted by manipulations of
> single BlockDriverStates or of the BDS graph.
>
> The users of the BDS filename field were changed as follows:
> - copying the filename into another buffer is trivially replaced by
> using bdrv_filename() instead of the copy function
> - strdup() on the filename is replaced by a call to
> bdrv_filename_alloc()
> - bdrv_filename(bs, bs->filename, sizeof(bs->filename)) is replaced by
> bdrv_refresh_filename(bs)
> (these were introduced by the previous patch)
> - anywhere else bdrv_filename_alloc() is used, any access to
> BlockDriverState.filename is then replaced by the buffer returned, and
> it is freed when it is no longer needed
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
Looks like clean conversions.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
["signature.asc" (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic