[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-block
Subject:    Re: [Qemu-block] Creating snapshots with specific runtime options
From:       Alberto Garcia <berto () igalia ! com>
Date:       2015-08-28 8:28:32
Message-ID: w51h9njbyvj.fsf () maestria ! local ! igalia ! com
[Download RAW message or body]

On Wed 26 Aug 2015 02:57:13 PM CEST, Stefan Hajnoczi wrote:

>> In principle extending the QMP command sounds as simple as adding
>> 'options': 'BlockdevOptions' to 'blockdev-snapshot-sync', but it's
>> surely more complicated than that :) Is the 'BlockdevOptions' API
>> even stable?
>
> Some block drivers don't have BlockdevOptions support yet.
>
> I think that doesn't prevent us from passing BlockdevOptions to
> snapshot creation though.

Hmmm, I see however that there's overlap between blockdev-snapshot-sync
and BlockdevOptions.

You must indicate the target file in both. Format and node name are also
present in both (these are optional however)... we can of course check
that the values match and/or ignore some of them but that's horrible.

Berto


[prev in list] [next in list] [prev in thread] [next in thread]