[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-arm
Subject:    Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()
From:       Markus Armbruster <armbru () redhat ! com>
Date:       2020-06-30 9:48:43
Message-ID: 87eepwhojo.fsf () dusky ! pond ! sub ! org
[Download RAW message or body]

Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org> writes:

> We use "create_simple" names for functions that allocate, initialize,
> configure and realize device objects: pci_create_simple(),
> isa_create_simple(), usb_create_simple(). For consistency, rename
> i2c_create_slave() as i2c_slave_create_simple(). Since we have
> to update all the callers, also let it return a I2CSlave object.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>

Reviewed-by: Markus Armbruster <armbru@redhat.com>



[prev in list] [next in list] [prev in thread] [next in thread]