[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-arm
Subject:    Re: [PATCH 11/17] hw/misc/max111x: Create header file for documentation, TYPE_ macros
From:       Philippe_Mathieu-Daudé <f4bug () amsat ! org>
Date:       2020-06-29 14:57:12
Message-ID: 128760db-266b-092b-297c-d7c766174ced () amsat ! org
[Download RAW message or body]

On 6/29/20 2:07 PM, Peter Maydell wrote:
> On Mon, 29 Jun 2020 at 09:29, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> On 6/28/20 4:24 PM, Peter Maydell wrote:
>>> Create a header file for the hw/misc/max111x device, in the
>>> usual modern style for QOM devices:
>>>  * definition of the TYPE_ constants and macros
>>>  * definition of the device's state struct so that it can
>>>    be embedded in other structs if desired

Ah, fine.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>>>  * documentation of the interface
>>>
>>> This allows us to use TYPE_MAX_1111 in the spitz.c code rather
>>> than the string "max1111".
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
> 
>> Nitpick, we can keep MAX_111X() + MAX111xState in "hw/misc/max111x.c"
>> until we get a consumer.
> 
> This is deliberate, as noted in the commit message.
> 
> thanks
> -- PMM
> 


[prev in list] [next in list] [prev in thread] [next in thread]