[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-arm
Subject:    Re: [Qemu-arm] [Qemu-devel] [PATCH v5 2/2] hw/arm: add Arm SBSA reference machine, devices part
From:       Peter Maydell <peter.maydell () linaro ! org>
Date:       2019-01-31 9:48:37
Message-ID: CAFEAcA_i0dXNUfzKGBgn=riupWtBa=pGYYtY8LUqHdrf6YzbvQ () mail ! gmail ! com
[Download RAW message or body]

On Wed, 30 Jan 2019 at 08:23, Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Tue, 29 Jan 2019 15:26:29 +0000
> Peter Maydell <peter.maydell@linaro.org> wrote:
> > Oh, I see now. I think this is a bug in boot.c and we should
> > fix it by making the "this is a firmware boot" code path also
> > do the arm_load_dtb() call. I'll send a patch.
> pls, CC me on it as well.
>
> I'm interested in it from hotplug + reboot perspective,
> where we have a changed/bigger DTB on reboot as it contains new devices (cpus|memory)
>
> loading rom like now doesn't work nice in case of reboot.

OK, but I don't think it will help you there, because all it
does (after a pile of refactoring) is make the firmware-boot
code path go through the if() clause at the bottom of
arm_load_kernel() that calls arm_load_dtb().

thanks
-- PMM


[prev in list] [next in list] [prev in thread] [next in thread]