[prev in list] [next in list] [prev in thread] [next in thread] 

List:       python-patches
Subject:    [Patches] New Unicode Character Name \N{..} patches
From:       billtut () microsoft ! com (Bill Tutt)
Date:       2000-06-28 10:49:45
Message-ID: 4D0A23B3F74DD111ACCD00805F31D8101D8BD23F () RED-MSG-50
[Download RAW message or body]

I've tossed the new patch into the SF patch manager by updating #100642.

Bill

-----Original Message-----
From: M.-A. Lemburg [mailto:mal@lemburg.com]
Sent: Tuesday, June 27, 2000 5:14 AM
To: Bill Tutt
Cc: 'patches@python.org'
Subject: Re: [Patches] New Unicode Character Name \N{..} patches


[New version of the patch]

Great work :-)

Some minor nits:

* I think the inclusion of strnicmp will cause more compiler
  problems than do good -- why not simply inline the code in
  the one spot that needs it in unicodeobject.c ?

* The typedefs in ucnhash.h should probably have the _Py_
  prefix to make it clear that the code is part of the
  Python dist.

Could you submit this as patch to the SF patch manager (with
the new files included) ?!

Thanks,
-- 
Marc-Andre Lemburg
______________________________________________________________________
Business:                                      http://www.lemburg.com/
Python Pages:                           http://www.lemburg.com/python/


[prev in list] [next in list] [prev in thread] [next in thread]