[prev in list] [next in list] [prev in thread] [next in thread]
List: python-dev
Subject: Re: [Python-Dev] [Python-checkins] cpython: Issue #23152: Implement _Py_fstat() to support files lar
From: Steve Dower <Steve.Dower () microsoft ! com>
Date: 2015-02-21 23:28:51
Message-ID: DM2PR0301MB0734C4B81A0E7D0C8BA81692F52B0 () DM2PR0301MB0734 ! namprd03 ! prod ! outlook ! com
[Download RAW message or body]
Agreed. I've made both of these changes.
Thanks for the suggestions
Cheers,
Steve
Top-posted from my Windows Phone
________________________________
From: Brett Cannon<mailto:brett@python.org>
Sent: =FD2/=FD21/=FD2015 14:13
To: Ben Hoyt<mailto:benhoyt@gmail.com>; Python-Dev<mailto:python-dev@python=
.org>
Subject: Re: [Python-Dev] [Python-checkins] cpython: Issue #23152: Implemen=
t _Py_fstat() to support files larger than 2 GB on
On Sat Feb 21 2015 at 4:23:16 PM Ben Hoyt <benhoyt@gmail.com<mailto:benhoyt=
@gmail.com>> wrote:
When merging some changes while working on scandir, I noticed a minor issue=
with this commit:
https://hg.python.org/cpython/rev/4f6f4aa0d80f
The definition of "struct win32_stat" has been moved to fileutils.h and ren=
amed to "struct _Py_stat_struct", which is fine -- however, the old "struct=
win32_stat" definition is still present (but unused) in posixmodule.c.
So I think the old "struct win32_stat { ... }" definition can simply be rem=
oved from posixmodule.c now.
I don't think win32_stat is part of the stable ABI so as long as everything=
keeps working then I don't see why it needs to stick around.
Also, unrelated to this commit, I notice the _Py_attribute_data_to_stat fun=
ction (was attribute_data_to_stat) can't fail and always returns 0, and all=
callers ignore its return value anyway. Can it be changed to return void?
Don't see why not since it's a private API.
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1256">
<meta content="text/html; charset=utf-8">
</head>
<body>
<div>
<div style="font-family:Calibri,sans-serif; font-size:11pt">Agreed. I've made both of \
these changes.<br> <br>
Thanks for the suggestions<br>
<br>
Cheers,<br>
Steve<br>
<br>
Top-posted from my Windows Phone</div>
</div>
<div dir="ltr">
<hr>
<span style="font-family:Calibri,sans-serif; font-size:11pt; font-weight:bold">From:
</span><span style="font-family:Calibri,sans-serif; font-size:11pt"><a \
href="mailto:brett@python.org">Brett Cannon</a></span><br> <span \
style="font-family:Calibri,sans-serif; font-size:11pt; font-weight:bold">Sent: \
</span><span style="font-family:Calibri,sans-serif; font-size:11pt">ý2/ý21/ý2015 \
14:13</span><br> <span style="font-family:Calibri,sans-serif; font-size:11pt; \
font-weight:bold">To: </span><span style="font-family:Calibri,sans-serif; \
font-size:11pt"><a href="mailto:benhoyt@gmail.com">Ben Hoyt</a>; <a \
href="mailto:python-dev@python.org">Python-Dev</a></span><br> <span \
style="font-family:Calibri,sans-serif; font-size:11pt; font-weight:bold">Subject: \
</span><span style="font-family:Calibri,sans-serif; font-size:11pt">Re: [Python-Dev] \
[Python-checkins] cpython: Issue #23152: Implement _Py_fstat() to support files \
larger than 2 GB on</span><br> <br>
</div>
<div>
<div dir="ltr"><br>
<br>
<div class="gmail_quote">On Sat Feb 21 2015 at 4:23:16 PM Ben Hoyt <<a \
href="mailto:benhoyt@gmail.com">benhoyt@gmail.com</a>> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; \
padding-left:1ex"> <div dir="ltr">When merging some changes while working on scandir, \
I noticed a minor issue with this commit: <div><br>
</div>
<div><a href="https://hg.python.org/cpython/rev/4f6f4aa0d80f" \
target="_blank">https://hg.python.org/cpython/rev/4f6f4aa0d80f</a> <div><br>
</div>
<div>The definition of "struct win32_stat" has been moved to fileutils.h \
and renamed to "struct _Py_stat_struct", which is fine -- however, the old \
"struct win32_stat" definition is still present (but unused) in \
posixmodule.c.</div> </div>
<div><br>
</div>
<div>So I think the old "struct win32_stat { ... }" definition can simply \
be removed from posixmodule.c now.</div> </div>
</blockquote>
<div><br>
</div>
<div>I don't think win32_stat is part of the stable ABI so as long as everything \
keeps working then I don't see why it needs to stick around.</div> <div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; \
padding-left:1ex"> <div dir="ltr">
<div><br>
</div>
<div>Also, unrelated to this commit, I notice the _Py_attribute_data_to_stat \
function (was attribute_data_to_stat) can't fail and always returns 0, and all \
callers ignore its return value anyway. Can it be changed to return void?</div> \
</div> </blockquote>
<div><br>
</div>
<div>Don't see why not since it's a private API. </div>
</div>
</div>
</div>
</body>
</html>
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: https://mail.python.org/mailman/options/python-dev/python-dev-marcsub-zyf4%40marc.info
--===============1817997913==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic