[prev in list] [next in list] [prev in thread] [next in thread] 

List:       python-dev
Subject:    Re: [Python-Dev] whitespace normalization pre-commit hook is giving
From:       "Brett Cannon" <brett () python ! org>
Date:       2007-05-29 17:38:31
Message-ID: bbaeab100705291038g1e110b69xe13c11a9bd227d73 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

[Attachment #4 (text/plain)]

On 5/28/07, "Martin v. Löwis" <martin@v.loewis.de> wrote:
>
> Brett Cannon schrieb:
> > Unfortunately the pre-commit hook
> > does not specify what line a change was made on so I have no clue where
> > it is failing (maybe this should be added?).
>
> It creates a reindent.Reindenter on the new contents, then invokes
> .run() on it, and complains if that returns true. If you can come
> up with a patch to reindent that makes it report more detailed
> errors, please post it, and I'll try to merge it into the hook
> script.



The commit worked.  Thanks for fixing this, Martin!  And thanks to Georg for
finding the initial solution.  And thanks to Neal for trying Georg's initial
solution.

-Brett

[Attachment #5 (text/html)]

<br><br><div><span class="gmail_quote">On 5/28/07, <b \
class="gmail_sendername">&quot;Martin v. Löwis&quot;</b> &lt;<a \
href="mailto:martin@v.loewis.de">martin@v.loewis.de</a>&gt; wrote:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> Brett Cannon schrieb:<br>&gt; Unfortunately the \
pre-commit hook<br>&gt; does not specify what line a change was made on so I have no \
clue where<br>&gt; it is failing (maybe this should be added?).<br><br>It creates a \
reindent.Reindenter  on the new contents, then invokes<br>.run() on it, and complains \
if that returns true. If you can come<br>up with a patch to reindent that makes it \
report more detailed<br>errors, please post it, and I&#39;ll try to merge it into the \
hook <br>script.</blockquote><div><br><br>The commit worked.&nbsp; Thanks for fixing \
this, Martin!&nbsp; And thanks to Georg for finding the initial solution.&nbsp; And \
thanks to Neal for trying Georg&#39;s initial solution.<br><br>-Brett<br> \
</div><br></div><br>



_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: http://mail.python.org/mailman/options/python-dev/python-dev%40progressive-comp.com


[prev in list] [next in list] [prev in thread] [next in thread]