[prev in list] [next in list] [prev in thread] [next in thread] 

List:       python-bugs-list
Subject:    [issue14963] Use an iterative implementation for contextlib.ExitStack.__exit__
From:       Nick Coghlan <report () bugs ! python ! org>
Date:       2012-05-31 14:08:40
Message-ID: 1338473320.21.0.199987745598.issue14963 () psf ! upfronthosting ! co ! za
[Download RAW message or body]


Nick Coghlan <ncoghlan@gmail.com> added the comment:

Interesting - it turns out we can't fully reproduce the behaviour of nested with \
statements in ExitStack (see the new reference test I checked in, as well as #14969)

I added one technically redundant variable to the implementation to make it more \
obviously correct to the reader, as well as a test that ensures the stack can handle \
ridiculous numbers of callbacks without failing (a key advantage of using a single \
frame rather than one frame per callback)

While it isn't mandatory, we prefer it if contributors submit Contributor Agreements \
even for small changes. If you're happy to do that, I consider emailing a scanned or \
digitally photographed copy of the signed form as described here to be the simplest \
currently available approach: http://www.python.org/psf/contrib/

----------
resolution: fixed -> 
stage: committed/rejected -> test needed
status: closed -> open

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14963>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-bugs-list%40marc.info



[prev in list] [next in list] [prev in thread] [next in thread]