[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pykde
Subject:    Re: Slight Issues with sip_array.c format being specified
From:       Phil Thompson <phil () riverbankcomputing ! com>
Date:       2023-07-04 10:19:18
Message-ID: 81ecd79fb1bb12b138410a8f38437b8c () riverbankcomputing ! com
[Download RAW message or body]

On 26/06/2023 06:47, Ognyan Moore wrote:
> Hi Phil,
> 
> Just came across an issue in sip_array.c::sipArray_getbuffer
> 
> code to reproduce:
> 
>>>> from PyQt6 import sip, QtCore
>>>> memoryview(sip.array(QtCore.QPointF, 2))
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> BufferError: format has not been specified
> 
> Looks like non-scalar types don't have a format, and if the requestor
> requests a buffer format to be specified and there isn't one, an 
> exception
> is raised.
> 
> A more sensible default might be to set the format to bytes in this 
> case.
> There is some precedence here as python's PyBuffer_FillInfo will 
> populate
> format as "B".

Done in the next snapshot.

Thanks,
Phil
[prev in list] [next in list] [prev in thread] [next in thread]