[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pykde
Subject:    [PyQt] pyqtdeploy-2.2 : minor error in sysroot.py
From:       suizokukan <suizokukan () orange ! fr>
Date:       2018-11-14 10:41:02
Message-ID: 1311956024.4765.1542192062621.JavaMail.www () wwinf1f11
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

  

it seems to me there's a minor bug in pyqtdeploy-2.2/pyqtdeploy/sysroot/sysroot.py. \
Line 231, instead of :  toolchain_version = \
os.environ.get('ANDROID_NDK_TOOLCHAIN_VERSION') if toolchain_version is None:
sysroot.error(
"the ANDROID_NDK_TOOLCHAIN_VERSION environment variable "
"must be set to an appropriate value (e.g. '4.9')")
  
we should read:
  
  toolchain_version = os.environ.get('ANDROID_NDK_TOOLCHAIN_VERSION')
if toolchain_version is None:
self.error(
"the ANDROID_NDK_TOOLCHAIN_VERSION environment variable "
"must be set to an appropriate value (e.g. '4.9')")
  

... in order to avoid the NameError I got. In this file every call to .error() but \
this line is written self.error() .

  

suizokukan (Xavier Faure)

  


[Attachment #5 (text/html)]

<div class="mod-content">
<div id="description-val" class="field-ignore-highlight">
<div class="user-content-block">
<p>Hello,</p>
<p>  </p>
<p>it seems to me there's a minor bug in \
pyqtdeploy-2.2/pyqtdeploy/sysroot/sysroot.py. Line 231, instead of :<br />   \
toolchain_version = os.environ.get('ANDROID_NDK_TOOLCHAIN_VERSION')<br /> if \
toolchain_version is None:<br /> sysroot.error(<br /> "the \
ANDROID_NDK_TOOLCHAIN_VERSION environment variable "<br /> "must be set to an \
appropriate value (e.g. '4.9')")<br />   <br /> we should read:<br />   <br />   \
toolchain_version = os.environ.get('ANDROID_NDK_TOOLCHAIN_VERSION')<br /> if \
toolchain_version is None:<br /> self.error(<br /> "the ANDROID_NDK_TOOLCHAIN_VERSION \
environment variable "<br /> "must be set to an appropriate value (e.g. '4.9')")<br \
/>   </p> <p>... in order to avoid the NameError I got. In this file every call to \
.error() but this line is written self.error() .</p> <p>  </p>
<p>suizokukan (Xavier Faure)</p>
<p>  </p>
</div>
</div>
</div>


[Attachment #6 (text/plain)]

_______________________________________________
PyQt mailing list    PyQt@riverbankcomputing.com
https://www.riverbankcomputing.com/mailman/listinfo/pyqt

[prev in list] [next in list] [prev in thread] [next in thread]