[prev in list] [next in list] [prev in thread] [next in thread]
List: pykde
Subject: Re: [PyQt] sip changesets 71a8ee38b2c6 & 948e06cb1921 (sip 4.19.1) break QGIS
From: Alessandro Pasotti <apasotti () gmail ! com>
Date: 2017-02-22 11:11:17
Message-ID: CAL5Q671ffkT1wyoec-RfkgDMQL2O4T3ai8-u2g27__k649qZ1w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
I'm the author of that class, I don't know if that matters but the dtor is
private, the object destruction is handled by the instance with a call to
deleteLater.
in qgsfiledownloader.h (and in the SIP file as well):
private:
~QgsFileDownloader();
I hope it helps.
On Wed, Feb 22, 2017 at 10:32 AM, Phil Thompson <phil@riverbankcomputing.com
> wrote:
> On 22 Feb 2017, at 3:49 am, Doug Newgard <scimmia@archlinux.info> wrote:
> >
> > QGIS builds fine with sip 4.19, but fails with 4.19.1. I bisected and
> found
> > that these two changesets are where things go wrong, it builds fine with
> > 6b23496bd532 and earlier but fails with the following errors with
> 948e06cb1921
> > and later.
> >
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:5798:7:
> error: delet
> > ed function ‘virtual sipQgsFileDownloader::~sipQgsFileDownloader()'
> > }
> > ^
> > In file included from /home/dnewgard/PKGBUILDs/qgis/
> src/qgis-2.18.3/python/gui/qgsfiledownloader.sip
> > :33:0:
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/python/../src/gui/qgsfiledownloader.h:94:5:
> error: ove
> > rriding non-deleted function ‘virtual QgsFileDownloader::~
> QgsFileDownloader()'
> > ~QgsFileDownloader();
> > ^
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:5798:7:
> note: ‘virtu
> > al sipQgsFileDownloader::~sipQgsFileDownloader()' is implicitly deleted
> because the default definiti
> > on would be ill-formed:
> > }
> > ^
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:5798:7:
> error: ‘virt
> > ual QgsFileDownloader::~QgsFileDownloader()' is private within this
> context
> > In file included from /home/dnewgard/PKGBUILDs/qgis/
> src/qgis-2.18.3/python/gui/qgsfiledownloader.sip
> > :33:0:
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/python/../src/gui/qgsfiledownloader.h:94:5:
> note: decl
> > ared private here
> > ~QgsFileDownloader();
> > ^
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:
> In constructor ‘sip
> > QgsFileDownloader::sipQgsFileDownloader(QUrl, QString, bool)':
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:5830:122:
> error: ‘Qg
> > sFileDownloader::~QgsFileDownloader()' is private within this context
> > bool sipQgsFileDownloader::eventFilter( ::QObject*a0, ::QEvent*a1)
> >
> > ^
> > In file included from /home/dnewgard/PKGBUILDs/qgis/
> src/qgis-2.18.3/python/gui/qgsfiledownloader.sip
> > :33:0:
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/python/../src/gui/qgsfiledownloader.h:94:5:
> note: declared private here
> > ~QgsFileDownloader();
> > ^
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:
> In function ‘void release_QgsFileDownloader(void*, int)':
> > /home/dnewgard/PKGBUILDs/qgis/src/qgis-2.18.3/build/python/gui/sip_guipart3.cpp:6028:64:
> error: use of deleted function ‘virtual sipQgsFileDownloader::~
> sipQgsFileDownloader()'
> > return NULL;
> > ^
> >
> >
> > I know little about sip, is this a regression with sip or something that
> QGIS
> > needs to fix? With both changesets talking about fixing regressions, I
> > wouldn't expect them to break things, so I'm trying here first.
>
> You need to compare the definitions of the QgsFileDownloader dtor in the
> .h and .sip files.
>
> Phil
> _______________________________________________
> PyQt mailing list PyQt@riverbankcomputing.com
> https://www.riverbankcomputing.com/mailman/listinfo/pyqt
>
--
Alessandro Pasotti
w3: www.itopen.it
[Attachment #5 (text/html)]
<div dir="ltr"><div><div><div>Hi,<br><br></div>I'm the author of that class, I \
don't know if that matters but the dtor is private, the object destruction is \
handled by the instance with a call to deleteLater.<br><br><br>in qgsfiledownloader.h \
(and in the SIP file as well):<br><br> private:<br> \
~QgsFileDownloader();<br><br></div><br></div>I hope it \
helps.<br><br><div><div><br></div></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Wed, Feb 22, 2017 at 10:32 AM, Phil Thompson <span \
dir="ltr"><<a href="mailto:phil@riverbankcomputing.com" \
target="_blank">phil@riverbankcomputing.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 22 Feb 2017, at 3:49 \
am, Doug Newgard <<a \
href="mailto:scimmia@archlinux.info">scimmia@archlinux.info</a>> wrote:<br> \
><br> > QGIS builds fine with sip 4.19, but fails with 4.19.1. I bisected and \
found<br> > that these two changesets are where things go wrong, it builds fine \
with<br> > 6b23496bd532 and earlier but fails with the following errors with \
948e06cb1921<br> > and later.<br>
><br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp:5798:7: \
error: delet<br> > ed function ‘virtual \
sipQgsFileDownloader::~<wbr>sipQgsFileDownloader()'<br> > }<br>
> ^<br>
> In file included from \
/home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/gui/<wbr>qgsfiledownloader.sip<br>
> :33:0:<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/../src/<wbr>gui/qgsfiledownloader.h:94:5: \
error: ove<br> > rriding non-deleted function ‘virtual \
QgsFileDownloader::~<wbr>QgsFileDownloader()'<br> > ~QgsFileDownloader();<br>
> ^<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp:5798:7: \
note: ‘virtu<br> > al sipQgsFileDownloader::~<wbr>sipQgsFileDownloader()' is \
implicitly deleted because the default definiti<br> > on would be ill-formed:<br>
> }<br>
> ^<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp:5798:7: \
error: ‘virt<br> > ual QgsFileDownloader::~<wbr>QgsFileDownloader()' is private \
within this context<br> > In file included from \
/home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/gui/<wbr>qgsfiledownloader.sip<br>
> :33:0:<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/../src/<wbr>gui/qgsfiledownloader.h:94:5: \
note: decl<br> > ared private here<br>
> ~QgsFileDownloader();<br>
> ^<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp: \
In constructor ‘sip<br> > QgsFileDownloader::<wbr>sipQgsFileDownloader(QUrl, \
QString, bool)':<br> > \
/home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp:5830:122: \
error: ‘Qg<br> > sFileDownloader::~<wbr>QgsFileDownloader()' is private within \
this context<br> > bool sipQgsFileDownloader::<wbr>eventFilter( ::QObject*a0, \
::QEvent*a1)<br> ><br>
> ^<br>
> In file included from \
/home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/gui/<wbr>qgsfiledownloader.sip<br>
> :33:0:<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/python/../src/<wbr>gui/qgsfiledownloader.h:94:5: \
note: declared private here<br> > ~QgsFileDownloader();<br>
> ^<br>
> /home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp: \
In function ‘void release_QgsFileDownloader(<wbr>void*, int)':<br> > \
/home/dnewgard/PKGBUILDs/qgis/<wbr>src/qgis-2.18.3/build/python/<wbr>gui/sip_guipart3.cpp:6028:64: \
error: use of deleted function ‘virtual \
sipQgsFileDownloader::~<wbr>sipQgsFileDownloader()'<br> > \
return NULL;<br> > \
^<br> ><br>
><br>
> I know little about sip, is this a regression with sip or something that \
QGIS<br> > needs to fix? With both changesets talking about fixing regressions, \
I<br> > wouldn't expect them to break things, so I'm trying here \
first.<br> <br>
</div></div>You need to compare the definitions of the QgsFileDownloader dtor in the \
.h and .sip files.<br> <span class="HOEnZb"><font color="#888888"><br>
Phil<br>
</font></span><div class="HOEnZb"><div \
class="h5">______________________________<wbr>_________________<br> PyQt mailing list \
<a href="mailto:PyQt@riverbankcomputing.com">PyQt@riverbankcomputing.com</a><br> <a \
href="https://www.riverbankcomputing.com/mailman/listinfo/pyqt" rel="noreferrer" \
target="_blank">https://www.<wbr>riverbankcomputing.com/<wbr>mailman/listinfo/pyqt</a></div></div></blockquote></div><br><br \
clear="all"><br>-- <br><div class="gmail_signature" \
data-smartmail="gmail_signature">Alessandro Pasotti<br>w3: <a \
href="http://www.itopen.it" target="_blank">www.itopen.it</a></div> </div>
[Attachment #6 (text/plain)]
_______________________________________________
PyQt mailing list PyQt@riverbankcomputing.com
https://www.riverbankcomputing.com/mailman/listinfo/pyqt
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic