[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pykde
Subject:    [PyKDE] Re: [PATCH] some more build.py tweaks
From:       Hans-Peter Jansen <hpj () urpla ! net>
Date:       2003-04-25 22:10:40
[Download RAW message or body]

On Friday 25 April 2003 02:26, Jim Bublitz wrote:
> On 24-Apr-03 Hans-Peter Jansen wrote:
> >
> > top of KDE 3.1.1. First, I had to comment out the sessionSaving
> > method in kapplication.sip, are you sure, that this exists in
> > 3.1.1?
>
> It does in my kdelibs source/ and kde3.1.1/include - check yours
> and see if there's a distribution difference there. It's a new
> method in KDE 3.1.1 and correctly versioned in the sip file (and
> there's only one copy of the sip file that I test build all
> versions/tarballs from).

You're right. I should never trust a SuSE beta version. Today, I've 
updated to 8.2, and it builds fine without. Sorry for the confusion. 

I've attached a small build.py patch to fix the split logic. It 
avoids creating a superflous module. Phil: it applies to PyQt also 
with offset. 

Pete
["PyKDE-build4.diff" (text/x-diff)]

--- build.py~	2003-04-26 00:17:45.000000000 +0200
+++ build.py	2003-04-26 00:45:11.000000000 +0200
@@ -1296,10 +1296,13 @@
             d.write(f.read())
             f.close()
 
         d.close()
 
+        # avoid dangling last module
+        if nrinpiece + 1 == len(srclist):
+            nrinpiece = nrinpiece + 1
         srclist = srclist[nrinpiece:]
         p = p + 1
 
     # Replace the C++ file names in the project file.
     buf = re.sub(pat,"SOURCES = " + string.join(plist," ") + "\n",buf)

_______________________________________________
PyKDE mailing list    PyKDE@mats.gmd.de
http://mats.gmd.de/mailman/listinfo/pykde

[prev in list] [next in list] [prev in thread] [next in thread]