[prev in list] [next in list] [prev in thread] [next in thread] 

List:       proftpd-devel
Subject:    [Proftpd-devel] Patch for bug in mod_tls.c
From:       Richard Koenning <Richard.Koenning () fujitsu-siemens ! com>
Date:       2004-02-10 15:10:39
Message-ID: 4028F46F.7010803 () fujitsu-siemens ! com
[Download RAW message or body]

Hello,
attached is a patch for a bug in mod_tls.c (ProFTPD 1.2.9) causing a 
core dump when the directive TLSRenegotiate is used and not all possible 
operands are used in the right order.
Ciao,
Richard
-- 
Dr. Richard W. Könning
Fujitsu Siemens Computers GmbH

["mod_tls.c.patch" (text/plain)]

--- proftpd-1.2.9/contrib/mod_tls.c.ori	2004-02-10 12:52:19.600698000 +0100
+++ proftpd-1.2.9/contrib/mod_tls.c	2004-02-10 12:48:28.230325000 +0100
@@ -2775,7 +2775,7 @@
   c->argv[3] = pcalloc(c->pool, sizeof(unsigned char));
   *((unsigned char *) c->argv[3]) = TRUE;
 
-  for (i = 1; i < cmd->argc; i++) {
+  for (i = 1; i < cmd->argc; /* empty */) {
     if (!strcmp(cmd->argv[i], "ctrl")) {
       int secs = atoi(cmd->argv[i+1]);
 
@@ -2790,7 +2790,7 @@
       i += 2;
     }
 
-    if (!strcmp(cmd->argv[i], "data")) {
+    else if (!strcmp(cmd->argv[i], "data")) {
       char *tmp = NULL;
       unsigned long kbytes = strtoul(cmd->argv[i+1], &tmp, 10);
 
@@ -2805,7 +2805,7 @@
       i += 2;
     }
 
-    if (!strcmp(cmd->argv[i], "required")) {
+    else if (!strcmp(cmd->argv[i], "required")) {
       int bool = get_boolean(cmd, i+1);
 
       if (bool != -1)
@@ -2819,7 +2819,7 @@
       i += 2;
     }
 
-    if (!strcmp(cmd->argv[i], "timeout")) {
+    else if (!strcmp(cmd->argv[i], "timeout")) {
       int secs = atoi(cmd->argv[i+1]);
       
       if (secs > 0)

-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
ProFTPD Developers List
<proftpd-devel@proftpd.org>
https://lists.sourceforge.net/lists/listinfo/proftp-devel

[prev in list] [next in list] [prev in thread] [next in thread]