[prev in list] [next in list] [prev in thread] [next in thread] 

List:       proftpd-committers
Subject:    [ProFTPD-committers]
From:       TJ Saunders <castaglia () users ! sourceforge ! net>
Date:       2011-09-24 6:38:42
Message-ID: E1R7Lsp-0003rn-Sg () sfs-ml-4 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Update of /cvsroot/proftp/proftpd/tests/t/lib/ProFTPD/Tests/Modules/mod_sftp
In directory vz-cvs-3.sog:/tmp/cvs-serv22386/t/lib/ProFTPD/Tests/Modules/mod_sftp

Modified Files:
	exec.pm 
Log Message:

Leave a long explanation to my future self about failures of a particular
unit test, and why it can happen (e.g. due to module load ordering).


Index: exec.pm
===================================================================
RCS file: /cvsroot/proftp/proftpd/tests/t/lib/ProFTPD/Tests/Modules/mod_sftp/exec.pm,v
 retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- exec.pm	20 Apr 2011 16:08:35 -0000	1.1
+++ exec.pm	24 Sep 2011 06:38:39 -0000	1.2
@@ -1573,6 +1573,18 @@
   unlink($log_file);
 }
 
+# NOTE: If this unit test is failing with an error like the following:
+#
+#  not ok ERROR sftp_exec_opt_send_stdout
+#  Test::Unit::ExceptionError:
+#  Can't connect to SSH2 server: [LIBSSH2_ERROR_SOCKET_NONE] (-1) Unable to exchange \
encryption keys at t/lib/ProFTPD/Tests/Modules/mod_sftp/exec.pm line 1693. +#
+# Then it is most likely caused by having mod_exec appear AFTER mod_sftp in
+# the --with-modules configure argument.  This means that mod_exec's sess_init
+# callback would run BEFORE mod_sftp's, which in turn means that mod_exec
+# would not be able to detect that this is an SSH connection (and thus
+# would not automatically disable the sendStdout ExecOptions).
+
 sub sftp_exec_opt_send_stdout {
   my $self = shift;
   my $tmpdir = $self->{tmpdir};


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
ProFTPD Committers Mailing List
proftpd-committers@proftpd.org
https://lists.sourceforge.net/lists/listinfo/proftp-committers


[prev in list] [next in list] [prev in thread] [next in thread]