[prev in list] [next in list] [prev in thread] [next in thread] 

List:       proftpd-committers
Subject:    [ProFTPD-committers] CVS: proftpd/contrib/mod_sftp scp.c, 1.24, 1.25
From:       "TJ Saunders" <castaglia () users ! sourceforge ! net>
Date:       2009-08-25 0:24:20
Message-ID: E1Mfjpk-0008Ul-JN () ddv4jf1 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Update of /cvsroot/proftp/proftpd/contrib/mod_sftp
In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv32647/contrib/mod_sftp

Modified Files:
	scp.c 
Log Message:

Adding comment/note to myself for future tweaking.


Index: scp.c
===================================================================
RCS file: /cvsroot/proftp/proftpd/contrib/mod_sftp/scp.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- scp.c	24 Aug 2009 02:16:52 -0000	1.24
+++ scp.c	25 Aug 2009 00:24:18 -0000	1.25
@@ -1276,6 +1276,12 @@
 
     /* If our channel window has closed, try handling some packets; hopefully
      * some of them are WINDOW_ADJUST messages.
+     *
+     * XXX I wonder if this can be more efficient by waiting until we
+     * have a certain amount of data buffered up (N * transfer data size?)
+     * AND the window is closed before handling incoming packets?  That way
+     * we can handle more WINDOW_ADJUSTS at a whack, at the cost of buffering
+     * more data in memory.  Hmm.
      */
     while (sftp_channel_get_windowsz(channel_id) == 0) {
       pr_signals_handle();


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
ProFTPD Committers Mailing List
proftpd-committers@proftpd.org
https://lists.sourceforge.net/lists/listinfo/proftp-committers
[prev in list] [next in list] [prev in thread] [next in thread]