[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-hackers
Subject:    Re: Set all variable-length fields of pg_attribute to null on column drop
From:       Robert Haas <robertmhaas () gmail ! com>
Date:       2023-11-30 16:45:09
Message-ID: CA+TgmobLKU+Naw8mk2qDYfqHQZ3xwvyNRaORWRVyzN4-G-kEew () mail ! gmail ! com
[Download RAW message or body]

On Thu, Nov 30, 2023 at 6:24 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> I noticed that when a column is dropped, RemoveAttributeById() clears
> out certain fields in pg_attribute, but it leaves the variable-length
> fields at the end (attacl, attoptions, and attfdwoptions) unchanged.
> This is probably harmless, but it seems wasteful and unclean, and leaves
> potentially dangling data lying around (for example, attacl could
> contain references to users that are later also dropped).
>
> I suggest the attached patch to set those fields to null when a column
> is marked as dropped.

I haven't reviewed the patch, but +1 for the idea.

-- 
Robert Haas
EDB: http://www.enterprisedb.com


[prev in list] [next in list] [prev in thread] [next in thread]