[prev in list] [next in list] [prev in thread] [next in thread]
List: postgresql-hackers
Subject: Re: Ignore heap rewrites for materialized views in logical replication
From: "Euler Taveira" <euler () eulerto ! com>
Date: 2022-05-31 14:57:43
Message-ID: 572b47ac-a0b0-41de-b2f5-2b29c71e64da () www ! fastmail ! com
[Download RAW message or body]
On Tue, May 31, 2022, at 11:13 AM, Amit Kapila wrote:
> I think we don't need the retry logical to check error, a simple
> wait_for_caught_up should be sufficient as we are doing in other
> tests. See attached. I have slightly modified the commit message as
> well. Kindly let me know what you think?
Your modification will hang until the test timeout without the patch. That's
why I avoided to use wait_for_caught_up and used a loop for fast exit on success
or failure. I'm fine with a simple test case like you proposed.
--
Euler Taveira
EDB https://www.enterprisedb.com/
[Attachment #3 (text/html)]
<!DOCTYPE html><html><head><title></title><style \
type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Tue, \
May 31, 2022, at 11:13 AM, Amit Kapila wrote:<br></div><blockquote type="cite" \
id="qt" style=""><div>I think we don't need the retry logical to check error, a \
simple<br></div><div>wait_for_caught_up should be sufficient as we are doing in \
other<br></div><div>tests. See attached. I have slightly modified the commit message \
as<br></div><div>well. Kindly let me know what you \
think?<br></div></blockquote><div>Your modification will hang until the test timeout \
without the patch. That's<br></div><div>why I avoided to use wait_for_caught_up and \
used a loop for fast exit on success<br></div><div>or failure. I'm fine with a \
simple test case like you proposed.</div><div><br></div><div><br></div><div \
id="sig112409080"><div class="signature">--<br></div><div class="signature">Euler \
Taveira<br></div><div class="signature">EDB <a \
href="https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></div></div><div><br></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic