[prev in list] [next in list] [prev in thread] [next in thread]
List: postgresql-general
Subject: Re: [HACKERS] SQL/JSON in PostgreSQL
From: Pavel Stehule <pavel.stehule () gmail ! com>
Date: 2017-09-30 4:28:52
Message-ID: CAFj8pRAK66XMdT-XQ_yp52p5Qw6m7LXPgd1L_kN3b=3JeMo1bA () mail ! gmail ! com
[Download RAW message or body]
2017-09-30 1:06 GMT+02:00 Nikita Glukhov <n.gluhov@postgrespro.ru>:
> On 29.09.2017 20:07, Pavel Stehule wrote:
>
> 2017-09-29 12:15 GMT+02:00 Pavel Stehule <pavel.stehule@gmail.com>:
>
>>
>> 2017-09-29 12:09 GMT+02:00 Nikita Glukhov <n.gluhov@postgrespro.ru>:
>>
>>>
>>>
>>> I have some free time now. Is it last version?
>>>
>>> Regards
>>>
>>> Pavel
>>>
>>> Yes, this is still the latest version. Now I am working only on
>>> unfinished WIP
>>> patch no. 9, but I think it should be reviewed the last.
>>>
>>>
>>
>> ok
>>
>> Thank you
>>
>
> I have few queries and notes
>
> 1. Why first patch holds Gin related functionality? Can be it separated?
>
> Yes, it can be easily separated. Attached archive with separated GIN patch
> no.2.
>
> 2. Why Json path functions starts by "_" ? These functions are not removed
> by other patches.
>
> Originally, these functions were created only for testing purposes and
> should
> be treated as "internal". But with introduction of jsonpath operators
> jsonpath
> tests can be completely rewritten using this operators.
>
> 3. What is base for jsonpath-extensions? ANSI/SQL?
>
> Our jsonpath extensions are not based on any standards, so they are quite
> dangerous because they can conflict with the standard in the future.
>
> This patch is pretty big - so I propose to push JSONPath and SQL/JSON
> related patches first, and then in next iteration to push JSON_TABLE patch.
> Is it acceptable strategy?
>
> I think it's acceptable. And this was the main reason for the separation
> of patches.
>
I prefer to move it to another commit fest item. It will simplify a
communication between us and possible committers - and we can better
concentrate to smaller set of code.
> I am sure so JSON_TABLE is pretty important function, but it is pretty
> complex too (significantly more complex than XMLTABLE), so it can be
> practiacal to move this function to separate project. I hope so all patches
> will be merged in release 11 time.
>
>
> --
> Nikita Glukhov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
[Attachment #3 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-09-30 \
1:06 GMT+02:00 Nikita Glukhov <span dir="ltr"><<a \
href="mailto:n.gluhov@postgrespro.ru" \
target="_blank">n.gluhov@postgrespro.ru</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<p>On 29.09.2017 20:07, Pavel Stehule wrote:<br>
</p>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">2017-09-29 12:15 GMT+02:00 Pavel
Stehule <span dir="ltr"><<a href="mailto:pavel.stehule@gmail.com" \
target="_blank">pavel.stehule@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote"><span \
class="m_5858760151899556962gmail-">2017-09-29 12:09 GMT+02:00 Nikita Glukhov <span \
dir="ltr"><<a href="mailto:n.gluhov@postgrespro.ru" \
target="_blank">n.gluhov@postgrespro.ru</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div \
bgcolor="#FFFFFF"> <div>
<div \
class="m_5858760151899556962gmail-m_-2941308544021042013h5"><br> <blockquote \
type="cite"> <div dir="ltr">
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>I have some free time now.
Is it last version?</div>
<div><br>
</div>
<div>Regards</div>
<div><br>
</div>
<div>Pavel</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
Yes, this is still the latest version. Now I
am working only on unfinished WIP<br>
patch no. 9, but I think it should be reviewed
the last.<span><br>
<br>
</span></div>
</blockquote>
<div><br>
</div>
<div><br>
</div>
</span>
<div>ok</div>
<div><br>
</div>
<div>Thank you</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I have few queries and notes<br>
</div>
<div><br>
</div>
<div>1. Why first patch holds Gin related functionality? Can
be it separated?</div>
</div>
</div>
</div>
</blockquote></span>
Yes, it can be easily separated. Attached archive with separated GIN
patch no.2.<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>2. Why Json path functions starts by "_" ? These
functions are not removed by other patches.<br>
</div>
</div>
</div>
</div>
</blockquote></span>
Originally, these functions were created only for testing purposes
and should<br>
be treated as "internal". But with introduction of jsonpath
operators jsonpath<br>
tests can be completely rewritten using this operators.<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>3. What is base for jsonpath-extensions? ANSI/SQL?</div>
</div>
</div>
</div>
</blockquote></span>
Our jsonpath extensions are not based on any standards, so they are
quite<br>
dangerous because they can conflict with the standard in the future.<span \
class=""><br> <br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>This patch is pretty big - so I propose to push
JSONPath and SQL/JSON related patches first, and then in
next iteration to push JSON_TABLE patch. Is it acceptable
strategy? </div>
</div>
</div>
</div>
</blockquote></span>
I think it's acceptable. And this was the main reason for the
separation of patches.<span \
class=""><br></span></div></blockquote><div><br></div><div>I prefer to move it to \
another commit fest item. It will simplify a communication between us and possible \
committers - and we can better concentrate to smaller set of \
code.<br></div><div><br></div><div> <br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
text="#000000" bgcolor="#FFFFFF"><span class=""> <br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>I am sure so JSON_TABLE is pretty important function,
but it is pretty complex too (significantly more complex
than XMLTABLE), so it can be practiacal to move this
function to separate project. I hope so all patches will
be merged in release 11 time.</div>
</div>
</div>
</div>
</blockquote>
<br>
</span><span class=""><div class="m_5858760151899556962moz-signature">-- <br>
Nikita Glukhov<br>
Postgres Professional: <a href="http://www.postgrespro.com" \
target="_blank">http://www.postgrespro.com</a><br> The Russian Postgres Company<br>
</div>
</span></div>
</blockquote></div><br></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic