[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] [BUGS] BUG #14759: insert into foreign data partitions fail
From:       "David G. Johnston" <david.g.johnston () gmail ! com>
Date:       2017-07-31 21:41:48
Message-ID: CAKFQuwYrSQHv5zaTUDQuno0NzqHAXTzX3DrE2HtmjcJJt8nS5g () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jul 25, 2017 at 11:29 PM, Amit Langote <
Langote_Amit_f8@lab.ntt.co.jp> wrote:

> > I'm curious what the other limitations are...
>
> When I first wrote that documentation line (I am assuming you're asking
> about "although these have some limitations that normal tables do not"), I
> was thinking about the fact that the core system does not enforce
> (locally) any constraints defined on foreign tables.  Since we allow
> inserting data into partitions directly, it is imperative that we enforce
> the "partition constraint" along with the traditional constraints such as
> NOT NULL and CHECK constraints, which we can do for local table partitions
> but not for foreign table ones.
>
> Anyway, attached patch documents all these limitations about foreign table
> partitions more prominently.
>

​The revised patch down-thread looks good.  Thanks.

I indeed was referring to the paragraph you quoted.

​I would probably just   s/For example/In particular/   and call it good -
or maybe also tell the user that all the limitations are listed in the
notes section for create foreign table (though my first thoughts are all
quite wordy).

David J.

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><span \
style="font-family:arial,sans-serif">On Tue, Jul 25, 2017 at 11:29 PM, Amit Langote \
</span><span dir="ltr" style="font-family:arial,sans-serif">&lt;<a \
href="mailto:Langote_Amit_f8@lab.ntt.co.jp" \
target="_blank">Langote_Amit_f8@lab.ntt.co.jp</a>&gt;</span><span \
style="font-family:arial,sans-serif"> wrote:</span><br></div><div \
class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span \
class="">&gt; I&#39;m curious what the other limitations are...<br> <br>
</span>When I first wrote that documentation line (I am assuming you&#39;re \
asking<br> about &quot;although these have some limitations that normal tables do \
not&quot;), I<br> was thinking about the fact that the core system does not \
enforce<br> (locally) any constraints defined on foreign tables.   Since we allow<br>
inserting data into partitions directly, it is imperative that we enforce<br>
the &quot;partition constraint&quot; along with the traditional constraints such \
as<br> NOT NULL and CHECK constraints, which we can do for local table partitions<br>
but not for foreign table ones.<br>
<br>
Anyway, attached patch documents all these limitations about foreign table<br>
partitions more prominently.<br></blockquote><div><br></div><div \
class="gmail_default" style="font-family:arial,helvetica,sans-serif">​The revised \
patch down-thread looks good.   Thanks.</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">I indeed was referring to the \
paragraph you quoted.</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">​I would probably just    s/For \
example/In particular/    and call it good - or maybe also tell the user that all the \
limitations are listed in the notes section for create foreign table (though my first \
thoughts are all quite wordy).</div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" \
style="font-family:arial,helvetica,sans-serif">David J.</div></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]