[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Out of date comment in predicate.c
From:       Peter Eisentraut <peter.eisentraut () 2ndquadrant ! com>
Date:       2017-06-30 18:38:18
Message-ID: 1a0efd3e-97b7-707e-d851-54cad0118999 () 2ndquadrant ! com
[Download RAW message or body]

On 6/27/17 01:21, Thomas Munro wrote:
> Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of
> FirstPredicateLockMgrLock, but it's still referred to in a comment in
> predicate.c where the locking protocol is documented.  I think it's
> probably best to use the name of the macro that's usually used to
> access the lock array in the code.  Please see attached.

Does this apply equally to PredicateLockHashPartitionLock() and
PredicateLockHashPartitionLockByIndex()?  Should the comment mention or
imply both?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]