[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] copyParamList
From:       Robert Haas <robertmhaas () gmail ! com>
Date:       2016-05-31 16:40:03
Message-ID: CA+TgmobEPjfRCP0=wG-SEZ8mebgB-=-pkFyNtrYgcD31Tx=+VQ () mail ! gmail ! com
[Download RAW message or body]

On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth
<andrew@tao11.riddles.org.uk> wrote:
> copyParamList does not respect from->paramMask, in what looks to me like
> an obvious oversight:
>
>     retval->paramMask = NULL;
> [...]
>         /* Ignore parameters we don't need, to save cycles and space. */
>         if (retval->paramMask != NULL &&
>             !bms_is_member(i, retval->paramMask))
>
> retval->paramMask is never set to anything not NULL in this function,
> so surely that should either be initializing it to from->paramMask, or
> checking from->paramMask in the conditional?

Oh, dear.  I think you are right.  I'm kind of surprised this didn't
provoke a test failure somewhere.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]