[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] patch: prevent user from setting wal_buffers over 2GB bytes
From:       Robert Haas <robertmhaas () gmail ! com>
Date:       2015-07-31 17:43:45
Message-ID: CA+Tgmob4Yj7KZszkjVHtkPX2HXQZf3WbXKW=KFg8+33F8QFR=g () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jul 30, 2015 at 9:17 PM, Josh Berkus <josh@agliodbs.com> wrote:
> In guc.c, the maximum for wal_buffers is INT_MAX.  However, wal_buffers
> is actually measured in 8KB buffers, not in bytes.  This means that
> users are able to set wal_buffers > 2GB.  When the database is started,
> this can cause a core dump if the WAL offset is > 2GB.

Why does this cause a core dump?  We could consider fixing whatever
the problem is rather than capping the value.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]