[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script
From:       Bruce Momjian <bruce () momjian ! us>
Date:       2015-04-30 16:55:35
Message-ID: 20150430165535.GA32364 () momjian ! us
[Download RAW message or body]

On Wed, Apr 29, 2015 at 11:59:26PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> 
> > I have developed the attached patch to use platform-specific quoting of
> > path names.
> 
> Part of me wonders about initdb's existing DIR_SEP and QUOTE_PATH
> definitions ... seems messy to reinvent these things all over again.

I don't think we can reuse QUOTE_PATH as it is used in initdb for
displaying potential ways of starting the server, and it assumes Unix
doesn't need quoting, while Windows usually does.  For an actual script,
we always want to use quoting.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]