[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Backup throttling
From:       Antonin Houska <antonin.houska () gmail ! com>
Date:       2013-07-31 20:50:19
Message-ID: 51F9788B.70007 () gmail ! com
[Download RAW message or body]

On 07/31/2013 07:13 AM, Gibheer wrote:
> Hi,
> 
> That is a really nice feature.
I don't pretend it's my idea, I just coded it. My boss proposed the 
feature as such :-)
> I took a first look at your patch and some empty lines you added (e.g. line 60 your \
> patch). Can you remove them?
Sure, will do in the next version.
> Why did you move localGetCurrentTimestamp() into streamutil.c? Is sys/time.h still \
> needed in receivelog.c after the move?
Because both receivelog.c and pg_basebackup.c need it now. I thought I 
could move localTimestampDifference() and 
localTimestampDifferenceExceeds() as well for the sake of consistency 
(these are actually utilities too) but I didn't get convinced enough 
that the feature alone justifies such a change.

As mentioned in 
http://www.postgresql.org/message-id/20130731173624.GX14652@eldon.alvh.no-ip.org 
these functions ideally shouldn't have separate implementation at all. 
However the problem is that pg_basebackup is not linked to the backend.

You're right about sys/time.h, it's included via via streamutil.h. I'll 
fix that too.
> I will try your patch later today to see, if it works.
> 
Whenever you have time. Thanks!

// Tony


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 07/31/2013 07:13 AM, Gibheer wrote:
    </div>
    <blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box"
      type="cite">
      <pre wrap="">
Hi,

That is a really nice feature.</pre>
    </blockquote>
    I don't pretend it's my idea, I just coded it. My boss proposed the
    feature as such :-)<br>
    <blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box"
      type="cite">
      <pre wrap="">I took a first look at your patch and some empty lines you added \
(e.g. line 60 your patch). Can you remove them?
</pre>
    </blockquote>
    Sure, will do in the next version.<br>
    <blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box"
      type="cite">
      <pre wrap="">
Why did you move localGetCurrentTimestamp() into streamutil.c? Is sys/time.h still \
needed in receivelog.c after the move? </pre>
    </blockquote>
    Because both receivelog.c and pg_basebackup.c need it now. I thought
    I could move localTimestampDifference() and
    localTimestampDifferenceExceeds() as well for the sake of
    consistency (these are actually utilities too) but I didn't get
    convinced enough that the feature alone justifies such a change.<br>
    <br>
    As mentioned in
    <meta http-equiv="content-type" content="text/html;
      charset=ISO-8859-1">
    <a
href="http://www.postgresql.org/message-id/20130731173624.GX14652@eldon.alvh.no-ip.org \
">http://www.postgresql.org/message-id/20130731173624.GX14652@eldon.alvh.no-ip.org</a>
  these functions ideally shouldn't have separate implementation at
    all. However the problem is that pg_basebackup is not linked to the
    backend.<br>
    <br>
    You're right about sys/time.h, it's included via via streamutil.h.
    I'll fix that too.<br>
    <blockquote cite="mid:20130731071336.1491c25b@linse.fritz.box"
      type="cite">
      <pre wrap="">
I will try your patch later today to see, if it works.

</pre>
    </blockquote>
    Whenever you have time. Thanks!<br>
    <br>
    // Tony<br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic