[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Eliminating PD_ALL_VISIBLE, take 2
From:       Robins <robins () pobox ! com>
Date:       2013-06-29 15:24:49
Message-ID: CAEP4nAz5xPvLAap3BgTDXEjYZGuhNHVMNbBhq35qSGrzH4vJgQ () mail ! gmail ! com
[Download RAW message or body]

On 10 June 2013 00:17, Jeff Davis <pgsql@j-davis.com> wrote:

> On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote:
> > > Come to think of it, even without the torn page & checksum issue, do we
> > > really want to actively clear the all-visible flags after upgrade?
>
> Removed that from the patch and rebased. I think the best approach is to
> remove the bit opportunistically when we're already dirtying the page
> for something else.
>
> However, right now, there is enough skepticism of the general approach
> in this patch (and enough related proposals) that I'll leave this to be
> resolved if and when there is more agreement that my approach is a good
> one.
>
>
Did some basic checks on this patch. List-wise feedback below.

- Cleanly applies to Git-Head: Yes (Some offsets, but thats probably
because of delay in review)
- Documentation Updated: No. (Required?)
- Tests Updated: No. (Required?)
- All tests pass: Yes
- Does it Work : ???

- Any visible issues: No
- Any compiler warnings: No

- Others:
Number of uncovered lines: Reduced by 167 lines

Robins Tharakan

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_extra">
<br><br><div class="gmail_quote">On 10 June 2013 00:17, Jeff Davis <span \
dir="ltr">&lt;<a href="mailto:pgsql@j-davis.com" \
target="_blank">pgsql@j-davis.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">

<div class="im">On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote:<br>
&gt; &gt; Come to think of it, even without the torn page &amp; checksum issue, do \
we<br> &gt; &gt; really want to actively clear the all-visible flags after \
upgrade?<br> <br>
</div>Removed that from the patch and rebased. I think the best approach is to<br>
remove the bit opportunistically when we&#39;re already dirtying the page<br>
for something else.<br>
<br>
However, right now, there is enough skepticism of the general approach<br>
in this patch (and enough related proposals) that I&#39;ll leave this to be<br>
resolved if and when there is more agreement that my approach is a good<br>
one.<br>
<br></blockquote></div><div class="gmail_default" style="font-family:trebuchet \
ms,sans-serif;font-size:small;color:rgb(0,0,0)"><br>Did some basic checks on this \
patch. List-wise feedback below.<br><br>- Cleanly applies to Git-Head: Yes (Some \
offsets, but thats probably because of delay in review)<br>

- Documentation Updated: No. (Required?)<br>- Tests Updated: No. (Required?)<br>- All \
tests pass: Yes<br>- Does it Work : ???<br><br>- Any visible issues: No<br>- Any \
compiler warnings: No<br><br>- Others: <br>Number of uncovered lines: Reduced by 167 \
lines<br>

<br>Robins Tharakan<br></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]